feat(query-optimization): implement GraphQL query optimization and enhance regression suite
- **Optimization**: Implemented automatic Zabbix parameter optimization by analyzing GraphQL selection sets. - **ZabbixRequest**: Added optimizeZabbixParams with support for skippable parameters and implied field dependencies (e.g., state -> items). - **Resolvers**: Updated allHosts, allDevices, allHostGroups, and templates to pass requested fields to data sources. - **Data Sources**: Optimized ZabbixQueryHostsGenericRequest and ZabbixQueryTemplatesRequest to skip unnecessary Zabbix API calls. - **Regression Tests**: Enhanced RegressionTestExecutor with new tests for optimization (REG-OPT, REG-OPT-NEG), state retrieval (REG-STATE), dependent items (REG-DEP), and empty results (REG-EMPTY). - **Documentation**: Created query_optimization.md How-To guide and updated roadmap.md, README.md, and tests.md. - **Bug Fixes**: Fixed deviceType tag assignment during host import and corrected ZabbixCreateHostRequest to support tags.
This commit is contained in:
parent
ad104acde2
commit
97a0f70fd6
16 changed files with 835 additions and 69 deletions
113
src/test/indirect_dependencies.test.ts
Normal file
113
src/test/indirect_dependencies.test.ts
Normal file
|
|
@ -0,0 +1,113 @@
|
|||
import {createResolvers} from "../api/resolvers.js";
|
||||
import {zabbixAPI} from "../datasources/zabbix-api.js";
|
||||
import {QueryAllDevicesArgs} from "../schema/generated/graphql.js";
|
||||
|
||||
// Mocking ZabbixAPI
|
||||
jest.mock("../datasources/zabbix-api.js", () => ({
|
||||
zabbixAPI: {
|
||||
executeRequest: jest.fn(),
|
||||
post: jest.fn(),
|
||||
baseURL: "http://mock-zabbix",
|
||||
}
|
||||
}));
|
||||
|
||||
// Mocking Config
|
||||
jest.mock("../common_utils.js", () => ({
|
||||
Config: {
|
||||
HOST_TYPE_FILTER_DEFAULT: null,
|
||||
HOST_GROUP_FILTER_DEFAULT: null
|
||||
}
|
||||
}));
|
||||
|
||||
describe("Indirect Dependencies Optimization", () => {
|
||||
let resolvers: any;
|
||||
|
||||
beforeEach(() => {
|
||||
jest.clearAllMocks();
|
||||
resolvers = createResolvers();
|
||||
});
|
||||
|
||||
test("allDevices optimization - state implies items", async () => {
|
||||
(zabbixAPI.post as jest.Mock).mockResolvedValueOnce([]);
|
||||
|
||||
const args: QueryAllDevicesArgs = {};
|
||||
const context = {
|
||||
zabbixAuthToken: "test-token",
|
||||
dataSources: { zabbixAPI: zabbixAPI }
|
||||
};
|
||||
const info = {
|
||||
fieldNodes: [{
|
||||
selectionSet: {
|
||||
selections: [
|
||||
{ kind: 'Field', name: { value: 'hostid' } },
|
||||
{ kind: 'Field', name: { value: 'state' } }
|
||||
]
|
||||
}
|
||||
}]
|
||||
};
|
||||
|
||||
await resolvers.Query.allDevices(null, args, context, info);
|
||||
|
||||
const callParams = (zabbixAPI.post as jest.Mock).mock.calls[0][1].body.params;
|
||||
expect(callParams.output).toContain("items");
|
||||
expect(callParams.selectItems).toBeDefined();
|
||||
});
|
||||
|
||||
test("allHosts optimization - inventory implies selectInventory", async () => {
|
||||
(zabbixAPI.post as jest.Mock).mockResolvedValueOnce([]);
|
||||
|
||||
const args = {};
|
||||
const context = {
|
||||
zabbixAuthToken: "test-token",
|
||||
dataSources: { zabbixAPI: zabbixAPI }
|
||||
};
|
||||
const info = {
|
||||
fieldNodes: [{
|
||||
selectionSet: {
|
||||
selections: [
|
||||
{ kind: 'Field', name: { value: 'inventory' } }
|
||||
]
|
||||
}
|
||||
}]
|
||||
};
|
||||
|
||||
await resolvers.Query.allHosts(null, args, context, info);
|
||||
|
||||
const callParams = (zabbixAPI.post as jest.Mock).mock.calls[0][1].body.params;
|
||||
// Zabbix inventory data is requested via selectInventory, and it maps to GraphQL 'inventory' field
|
||||
expect(callParams.selectInventory).toBeDefined();
|
||||
});
|
||||
|
||||
test("allHosts optimization - state fragment implies items", async () => {
|
||||
(zabbixAPI.post as jest.Mock).mockResolvedValueOnce([]);
|
||||
|
||||
const args = {};
|
||||
const context = {
|
||||
zabbixAuthToken: "test-token",
|
||||
dataSources: { zabbixAPI: zabbixAPI }
|
||||
};
|
||||
const info = {
|
||||
fieldNodes: [{
|
||||
selectionSet: {
|
||||
selections: [
|
||||
{
|
||||
kind: 'InlineFragment',
|
||||
typeCondition: { kind: 'NamedType', name: { value: 'Device' } },
|
||||
selectionSet: {
|
||||
selections: [
|
||||
{ kind: 'Field', name: { value: 'state' } }
|
||||
]
|
||||
}
|
||||
}
|
||||
]
|
||||
}
|
||||
}]
|
||||
};
|
||||
|
||||
await resolvers.Query.allHosts(null, args, context, info);
|
||||
|
||||
const callParams = (zabbixAPI.post as jest.Mock).mock.calls[0][1].body.params;
|
||||
expect(callParams.output).toContain("items");
|
||||
expect(callParams.selectItems).toBeDefined();
|
||||
});
|
||||
});
|
||||
Loading…
Add table
Add a link
Reference in a new issue